chore: deprecate planName and version flags, remove planId validation - #1540
Conversation
9aa4856 to
f0a77f7
Compare
…d version flags, remove planId validation
f0a77f7 to
bb24a68
Compare
|
PR lgtm from a technical stand point. Before: After: I've checked the redis api docs, but sadly the errors are not defined in the spec in a way we could reliably use here. But the "Before" error message is quite nice. It's formatted and also hints at |
I don't think we can do anything without verifying the plan beforehand. If the API gave a different error code then yeah, but i wouldn't want to start parsing the error message to "prettify" it in specific cases. |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Description
Applied for logme,mariadb,opensearch,rabbitmq and redis
Relates to STACKITCLI-440
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)